fix: allow retrying partial worktree removal - #3315

No actionable comments were generated in the recent review. 🎉

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to d4cd0

The recovery flow only permits removal after explicit confirmation and preserves the existing safety checks for leftover directories. No merge-blocking risk is identified.

• Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands.}

Greptile Summary

This PR allows an interrupted worktree removal to be retried when Git has already unregistered the checkout but left its directory behind.

• Recognizes Git’s “not a working tree” failure as requiring explicit force confirmation.
• Preserves the existing API error code and original Git message.
• Adds a regression test covering deferred API removal state, response behavior, and absence of premature workspace or event mutations.

Confidence Score: 5/5

The PR appears safe to merge because the new retry state remains explicitly confirmed and the existing forced-cleanup guards continue to reject registered or unrelated directories.

The change only enables confirmation after a recognized partial-removal error; operation identity and path matching protect modal state, and filesystem cleanup remains gated by registration and repository-identity checks.

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Deferred worktree removal] --> B{Git result}
  B -->|Success| C[Remove workspace and emit events]
  B -->|Dirty checkout| D[Return dirty_worktree_requires_force]
  B -->|Not a working tree| E[Return worktree_remove_failed]
  D --> F[Show explicit force confirmation]
  E --> F
  F --> G[Confirmed forced retry]
  G --> H{Path still registered or unrelated?}
  H -->|Yes| I[Reject cleanup]
  H -->|No, valid repository leftover| J[Remove leftover directory]

_{Reviews (1): Last reviewed commit: "fix: allow retrying partial worktree rem..." | Re-trigger Greptile}

@akbash-bot check if the feature is still needed, rebase and resolve conflicts, then get CI/reviews happy

Still needed: the regression test fails on current master when an open removal dialog receives Git’s “not a working tree” error. Rebased onto d184b41 and ported the fix to the client-owned dialog in d4cd005; server/API and deletion safeguards remain unchanged.

Full just check passes, including Windows cross-lint and 3,402 Rust tests. Linux, macOS, Windows, and packaging CI are green. CodeRabbit reviewed the new head without actionable code findings; no Greptile check appeared for this head.

The generic docstring warning counts four files, but this refreshed diff touches two and adds no function. I am leaving unrelated documentation unchanged.

Ready for maintainer review. Scope remains retrying within the open dialog; reopening after the checkout disappears from Git’s list is not addressed here.